search

decentralized-identity / confidential-storage

Confidential Storage Specification and Implementation
https://identity.foundation/confidential-storage/
Apache License 2.0
80 stars 23 forks source link

Possible query endpoint inconsistency #110

Closed DRK3 closed 3 years ago

DRK3 commented 4 years ago

Hi,

In the Searching Encrypted Documents section, it lists two ways to search through encrypted documents:

  1. Using a specifically indexed value
  2. Using the has keyword

In the examples, the endpoint for option 1 is listed as https://example.com/encrypted-data-vaults/{vaultID}, while the endpoint for option 2 is https://example.com/encrypted-data-vaults/{vaultID}/queries.

Are the endpoints being different intentional? The "queries" text in option 2 seems to suggest that it would be for all queries, but it also makes sense to me that the first path would be fine for all querying.

Thanks!

dlongley commented 4 years ago

Both endpoints should be the same, specifically: https://example.com/encrypted-data-vaults/{vaultId}/query

DRK3 commented 4 years ago

OK, thanks @dlongley :)