search

decentralized-identity / confidential-storage

Confidential Storage Specification and Implementation
https://identity.foundation/confidential-storage/
Apache License 2.0
80 stars 23 forks source link

To Base64URL or to Base58, that is the question #119

Closed csuwildcat closed 3 years ago

csuwildcat commented 3 years ago

Per nudge from @OR13, we should probably decide on an encoding to use across the spec.

OR13 commented 3 years ago

I'm dealing with versions of this everywhere thanks to the popularity of base58btc now, and the popularity of base64url before..... IMO, it totally sucks to have an API that requires both, so we should pick one...

Since IPFS and DID Core are newer and use base58btc... I suggest we just use that, and say fairwell to old and sad base64url without padding....

OR13 commented 3 years ago

All in favor of base58btc anywhere we can?

dlongley commented 3 years ago

I'm in favor of base58btc where we can ... but I'm not sure we can eliminate base64url everywhere... certainly not from other specs that we depend on/use (same applies in reverse); so I don't expect implementations to be able to get away with implementing just one.

OR13 commented 3 years ago

of course we can't change JOSE, but we can choose to never use base64url again.