decentralized-identity / credential-manifest

Format that normalizes the definition of requirements for the issuance of a credential
https://identity.foundation/credential-manifest/
Apache License 2.0
30 stars 22 forks source link

Credential Response example seems to not fit definition #115

Closed djvs closed 2 years ago

djvs commented 2 years ago

https://identity.foundation/credential-manifest/#credential-response-2

Noting in particular here, Credential Response is required to either have fulfillment or denial property, while the example contains neither? Is the example out of date?

decentralgabe commented 2 years ago

Example is out of date, thanks for flagging.

djvs commented 2 years ago

It looks like the actual context that jsonld attempts to resolve through needs to be updated as well. Not 100% sure how to access that file via https://identity.foundation/credential-manifest/response/v1. Noticed this stream of issues when the endpoint got renamed suddenly.

djvs commented 2 years ago

Is the verifiableCredential location, from the root of the response object, at $.credential_response.fulfillment.verifiableCredential?

decentralgabe commented 2 years ago

Is the verifiableCredential location, from the root of the response object, at $.credential_response.fulfillment.verifiableCredential?

no, the VC would be a separate property. so... $.verifiableCredential distinct from $.credential_response.??