Added missing schema properties to examples

decentralized-identity / credential-manifest

Format that normalizes the definition of requirements for the issuance of a credential

https://identity.foundation/credential-manifest/

Apache License 2.0

30 stars 22 forks source link

Added missing schema properties to examples #68

Closed DRK3 closed 2 years ago

DRK3 commented 3 years ago

The schema property is listed as required for Display Mapping Objects that use paths. This commit adds them in to examples where they're missing.
Also fixed some typos.

closes #65

DRK3 commented 2 years ago

@JaceHensley I've updated this PR for the latest version of the spec. I also updated the schemas. Something to note... the current schemas have the "path" property as mandatory, but I believe per the wallet-rendering spec that "text" could be used in place of "path". The "schema" property should really only be mandatory if "path" is being used, but since in the current schema "path" is listed as required, I made "schema" required as well.

JaceHensley commented 2 years ago

@DRK3 yes you are correct, I think we need to discuss how we want to keep these in sync. Ideally we could ratify a v0.1 of Wallet Rendering so CM can point to a specific version to implement against

csuwildcat commented 2 years ago

Will discuss with Jace on next PE/CM call.

bumblefudge commented 2 years ago

Discussed on today's call: Jace will work on this after cutting a static v0.1 for W-R and link to the relevant assets there

brentzundel commented 2 years ago

superseded by #82, closing