search

decentralized-identity / did-jwt

Create and verify DID verifiable JWT's in Javascript
Apache License 2.0
331 stars 70 forks source link

Documentation not updated #287

Closed user163 closed 11 months ago

user163 commented 1 year ago

The documentation should be adapted to the current state of development, e.g. for version 7.2.2 according to the documentation ES256KSigner: The supported encodings for the private key are hex, base64, base64url, and base58btc.

However, according to code only Uint8Array is allowed: function ES256KSigner(privateKey: Uint8Array, recoverable = false).

Note: Before version 6.0.0 it was indeed possible to pass the key in various binary-to-text encodings.

mirceanis commented 1 year ago

Thank you for reporting this! Are you planning to open a PR with the fix?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.