decentralized-identity / did-key.rs

Rust implementation of the did:key method
Apache License 2.0
47 stars 24 forks source link

Fix incorrect multicoded byte for sec5256k1. Test vectors added #29

Closed tmarkovski closed 2 years ago

tmarkovski commented 2 years ago

Fixes #28

vdods commented 2 years ago

Thanks! I was about to submit a PR for this. I do have more test cases, which I'll link to in a new issue. I believe there's a problem in the BLS key type (maybe is a subtle issue regarding G1 vs G2).

tmarkovski commented 2 years ago

Thanks! I was about to submit a PR for this. I do have more test cases, which I'll link to in a new issue. I believe there's a problem in the BLS key type (maybe is a subtle issue regarding G1 vs G2).

Quite possible. I've only done basic testing across implementations.