search

decentralized-identity / did-key.rs

Rust implementation of the did:key method
Apache License 2.0
47 stars 23 forks source link

signature_bls is abandoned #38

Closed pinkforest closed 6 months ago

pinkforest commented 1 year ago

Re: https://github.com/fission-codes/fission-cli/issues/21#issue-1465054547

I investigated and ockam seems to have dropped support for bls and it looks like they don't have a repository anymore for it either.

In any case this causes dependency duplication with bls12_381_plus and the latest signature_bls only brings ^0.5 whilst did-key brings ^0.7

I also queried with ockam at: https://github.com/build-trust/ockam/issues/3864 to clarify it.

Might need new bls signature crate to use or fork teh ockam one and bring the bls12_381_plus up.

mrinalwadhwa commented 1 year ago

Hi 👋 from the Ockam team. We're not using bls anymore and didn't realize did:key was using it directly :worried:. If someone would like to maintain it, we'd be happy to help get that started in whatever way we can.

pinkforest commented 1 year ago

Oh cool. Thanks for confirming it. Might just fork it - problem is that it's a monorepo so I can't retain the history unless I just filter the commits to re-build it hmm.

I'll also see if there is another crate that does ~similar thing and what the migration plan is.

If you really want I could adopt the crate but considering it only has 29k downloads a fork might be just in order.

It would be wonderful if you could publish note in the crate README that it's been sunset :)

tmarkovski commented 1 year ago

signature_bls has been removed in the #35 as it was confusing to use sign with a G1G2 key. I think the entire CoreSign trait doesn't belong in the did:key functionality, as the spec itself doesn't really define one.

pinkforest commented 1 year ago

Sweet, so shall be waiting a release for that then. Thanks!