search

decentralized-identity / did-resolver

Universal did-resolver for javascript environments
Apache License 2.0
213 stars 44 forks source link

Exporting the JsonWebKey interface #125

Closed bshambaugh closed 2 years ago

bshambaugh commented 2 years ago

Is there any reason why the JsonWebKey interface is not exported? I know it was used internally. but could it be?

https://github.com/decentralized-identity/did-resolver/blob/master/src/resolver.ts#L74-L86

mirceanis commented 2 years ago

There's no specific reason other than wanting to minimise the exported API, to reduce the maintenance burden. Besides this, the JsonWebKey defined here intentionally only refers to the public parts of a JWK, to discourage the use and leaking of private keys in DID documents.

We can close this after merging your PR #126

uport-automation-bot commented 2 years ago

:tada: This issue has been resolved in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: