decentralized-identity / didcomm-messaging

https://identity.foundation/didcomm-messaging/spec/
Apache License 2.0
165 stars 57 forks source link

various fixes suggested by Yolan (largely editorial) #377

Closed dhh1128 closed 2 years ago

TelegramSam commented 2 years ago

I like this, though my inline comments might guide an improvement for clarity.

dhh1128 commented 2 years ago

fixed #321

dhh1128 commented 2 years ago

@AnomalRoil : given that so much of the improvement in this PR comes from your proposals/recommendations, would you like to be listed as a contributor to the spec?

AnomalRoil commented 2 years ago

I'm good, I don't really feel like I contributed what I would have liked to change / contribute to it. If you have a thanks/reviewer section, feel free to add me there, otherwise feel free to drop me.

mccown commented 2 years ago

I also like the changes. Given the consensus, I'll go ahead and merge.