decentralized-identity / didcomm-messaging

https://identity.foundation/didcomm-messaging/spec/
Apache License 2.0
165 stars 57 forks source link

Incompatibility with the did peer specs in the 'serviceEndpoint' #438

Open FabioPinheiro opened 1 year ago

FabioPinheiro commented 1 year ago

In the DID Document the JSON path service.serviceEndpoint The examples on this specs are incompatible with the did peer specs

{
    "id": "did:example:123456789abcdefghi#didcomm-1",
    "type": "DIDCommMessaging",
    "serviceEndpoint": {
        "uri": "https://example.com/path",
        "accept": ["didcomm/v2","didcomm/aip2;env=rfc587"],
        "routingKeys": ["did:example:somemediator#somekey"]
    }
}

https://identity.foundation/peer-did-method-spec/#multi-key-creation

{
  "id": "did:peer:2.E....#didcommmessaging-0",
  "type": "DIDCommMessaging",
  "serviceEndpoint": "https://example.com/endpoint",
  "routingKeys": ["did:example:somemediator#somekey"],
  "accept": ["didcomm/v2", "didcomm/aip2;env=rfc587"]
}
FabioPinheiro commented 11 months ago

The peer-did-method was addressed by PR https://github.com/decentralized-identity/peer-did-method-spec/pull/62

This was also fixed on the did-core-spec

But we still need to fix on did-spec-registries

TelegramSam commented 8 months ago

PR needed on this repo: https://github.com/w3c/did-spec-registries/

FabioPinheiro commented 7 months ago

Here is the PR https://github.com/w3c/did-spec-registries/pull/548