decentralized-identity / didcomm.org

https://didcomm.org/
Apache License 2.0
37 stars 25 forks source link

message type uri gives a 404 error #20

Open TimoGlastra opened 2 years ago

TimoGlastra commented 2 years ago

When opening a protocol uri with the message type in your browser a 404 error is shown.

This means when you want to view the documentation for the message message in the basicmessage protocol you need to go to the following url:

# this does work
https://didcomm.org/basicmessage/2.0

instead of the following url

# this doesn't work
https://didcomm.org/basicmessage/2.0/message
TelegramSam commented 2 years ago

Excellent catch @TimoGlastra

brianorwhatever commented 2 years ago

I'm not sure how to do this with gatsby

a folder structure message/readme.md doesn't work and message.md doesn't work.. maybe we can just add wildcard resolution to everything after /2.0/?

TimoGlastra commented 2 years ago

maybe we can just add wildcard resolution to everything after /2.0/?

That sounds like a good solution to me.

brianorwhatever commented 2 years ago

I gave wildcard a look but don't know gatsby well enough so will try again later

brianorwhatever commented 2 years ago

unfortunately @wip-abramson it appears that #32 didn't work on the production site. See https://didcomm.org/basicmessage/1.0/test

I think this might be because the files are generated and served through github pages. The page resolver maybe doesn't use that section and that's why it works in dev but not prod? Just me guessing..

brianorwhatever commented 2 years ago

hmm on further testing with a local build it does appear to resolve subdirs but they have messed up CSS.. so maybe this is close

wip-abramson commented 2 years ago

Hmm yeah I am also not sure about this. I haven't used gh-pages much and never with gatsby. Will take another look at the code though when I get round to it.

wip-abramson commented 2 years ago

Okay, I think this describes our problem.

https://stackoverflow.com/questions/52051090/gatsbyjs-client-only-paths-goes-to-404-page-when-the-url-is-directly-accessed-in

We just need to figure out how to do the equivalent for gh-pages.