search

decentralized-identity / didcomm.org

https://didcomm.org/
Apache License 2.0
37 stars 25 forks source link

Discover Features Protocol 2.0 #51

Closed rodolfomiranda closed 2 years ago

rodolfomiranda commented 2 years ago

Add missing Discover Features Protocol from spec

TimoGlastra commented 2 years ago

The aries RFCs also define the discover features protocol 2.0. Are these fully compliant with each other? Or should the didcomm one have been version 3.0?

rodolfomiranda commented 2 years ago

The aries RFCs also define the discover features protocol 2.0. Are these fully compliant with each other? Or should the didcomm one have been version 3.0?

I missed it. I'll move that reference to 3.0 and add 1.0 and 2.0 from Aries

rodolfomiranda commented 2 years ago

The aries RFCs also define the discover features protocol 2.0. Are these fully compliant with each other? Or should the didcomm one have been version 3.0?

I missed it. I'll move that reference to 3.0 and add 1.0 and 2.0 from Aries

Here is the problem. DIDComm spec referenced it as 2.0 (there's also a typo in the disclose example showing 1.0 in the type header). Aries RFC 0557: Discover Features Protocol v2.x states that "Update to version 2.0 proposed in conjunction with DIDComm v2 efforts at DIF". So, both are in sync except for headers. How should we deal with versioning? that will happen also for other protocols

TelegramSam commented 2 years ago

So: This is a larger issue. I believe the semantics of the protocol are the same between the v2 defined in Aries, and v2 defined in the DIDComm spec. So, do we need a new version?

(The example with v2 specified is in error either way)

rodolfomiranda commented 2 years ago

Added reference to Aries and provide examples for both DIDComm v1 and v2