search

decentralized-identity / didcomm.org

https://didcomm.org/
Apache License 2.0
36 stars 25 forks source link

Add data agreement protocol #68

Closed lalc closed 1 year ago

lalc commented 1 year ago

Signed-off-by: Lal Chandran lal@igrant.io

TelegramSam commented 1 year ago

typically, each protocol is defined by itself. This allows for a unique Protocol Type URI for each. This PR has multiple protocols defined within the same file, and each would end up with the same URI. Would it be possible to split the protocols into different files in the same PR?

georgepadayatti commented 1 year ago

typically, each protocol is defined by itself. This allows for a unique Protocol Type URI for each. This PR has multiple protocols defined within the same file, and each would end up with the same URI. Would it be possible to split the protocols into different files in the same PR?

Made the changes as suggested.

TelegramSam commented 1 year ago

This is close - but you specified the protocol name in place of the message name. For example:

data-agreement-negotiation/1.0/offer

needs to be defined in data-agreement-negotiation/1.0/README.md, not in the current location of data-agreement/1.0/data-agreement-negotiation.md

Sorry for being painful - as is it won't work properly on the site for the generated pages.

lalc commented 1 year ago

@TelegramSam Is it ok to approve this and get this merged?