search

decentralized-identity / didcomm.org

https://didcomm.org/
Apache License 2.0
36 stars 25 forks source link

fix: Inconsistincies with mediation protocol #71

Closed TheTechmage closed 1 year ago

TheTechmage commented 1 year ago

When switching from using Keys in the mediation protocol to using DIDs in DIDComm V2, there were some inconsistencies within the API. The body of the requests were changes but the API was not, even though it was already a breaking change from 1.0 to 2.0. As part of my change, I have renamed 'keylist' to 'recipient' to more-so simplify changes in the future, should we switch from using DIDs to something else.

Also, the previous keylist response returned keys, rather than dids, which was inconsistent with the other keylist API calls and responses. This has been renamed to dids.

Language in other parts of the document has also been modified to reflect these changes.

2byrds commented 1 year ago

Alex is going to follow up with Veramo to check with them. We could potentially up the version of this protocol for this change.... meaning 2 would use keys for the name but actually use DIDs.... and version 3 would have these appropriately named DID fields.

TelegramSam commented 1 year ago

Discussed UG 20230227 - will create a v3 instead of this.