search

decentralized-identity / jsonld-common-java

Shared JSON-LD Java library.
Apache License 2.0
8 stars 6 forks source link

fix: build new JsonLDObject of JsonLDObject with non-empty DEFAULT_JS… #11

Open rkxx opened 1 year ago

rkxx commented 1 year ago

The changes in the pom file are required to run the unit tests (kotlin). Feel free to only merge the source changes and keep the project pure java.

Without the correction the test createDerivedJsonLDObjectWithDefaultContexts fails, because the property contexts of the resulting jsonLDObject contains a listOf(URI, listOf(URI)) instead of a flat listOf(URI, URI)

rkxx commented 1 year ago

Sorry, my fault. Intellij automatically ignored all formating changes so I wasn't aware of the mess. I have removed all formatting changes and unit tests. Is there any reason that you don't accept kotlin. It's really hard for me to fall back to plain Java. I did it for the existing sources, but would prefer to add new separated code using kotlin. Nevertheless, for the time being I removed the unit tests.

peacekeeper commented 1 year ago

Thanks, please check if you are a member of DIF and the Identifiers&Discovery Working Group, so we can accept the contribution: https://identity.foundation/join/