search

decentralized-identity / jwt-vc-presentation-profile

https://identity.foundation/jwt-vc-presentation-profile/
Apache License 2.0
15 stars 15 forks source link

Add terms to Terminology Section #42

Closed jischr closed 2 years ago

jischr commented 2 years ago

PR closes #8

I added a first round of terms that would be useful to a reader. Feel free to make an issue to add more terms that you think are required!

jischr commented 2 years ago

So someone does not need to click into the other links to figure out what the words referenced in this profile mean. Most all specs do this. there is a lot of repetition of terminology across specs i've read. usually they are defined with a "twist" as it relates to this profile.

Sakurann commented 2 years ago

the profile is not redefining these terms. if there is a "twist" in terminology, there is a problem

jischr commented 2 years ago

"Twist" might have been the wrong word here. it should define the term with an emphasis on how it relates to this profile. For example, an OpenID Provider in this context is OAuth2.0 Authentication Server implementing OIDC and OpenID4VP. In other contexts, it would just be an auth service implementing OIDC....

Sakurann commented 2 years ago

Thanks for the explanation. Yeah, I guess harmonizing terminology across specifications from various SDOs is a good thing

Sakurann commented 2 years ago

I think what's confusing to me is the inconsistency: some definitions are taken from specifications directly (eg holder), some are modified (eg SIOP) and some are introduced for the purpose of this profile (eg wallet). we should unify the approach

jischr commented 2 years ago

@Sakurann thanks for the feedback. updating now to unify.

jischr commented 2 years ago

@Sakurann good to go? you have to approve because of your "change requested"

Sakurann commented 2 years ago

Yes! Thanks a lot, Jen!