3formatfixes

[TelegramSam]

fixes #50

[TelegramSam]

@dbluhm does this adequately fix your issues?

Note the inclusion of the leading . of the method 2 DID string for consistency.

[dhh1128]

@dbluhm and @TelegramSam : are you ready for this to be merged?

[dbluhm]

I don't think this is ready -- I checked the example Sam used to see if that contained the expected multicodec prefix on the off chance that detail was just missed in the steps to create the DID. The example does not include the multicodec prefix. I think we should be consistent and include the prefix. Beyond just consistency, this leaves the door open for other hash algorithms in the future.

[TelegramSam]

@dbluhm I've fixed this - do me a favor and verify this with code (using my inputs) to see if you get the same results?

[dbluhm]

Verified with this quick program:

import sys
from multiformats import multibase, multihash

value = sys.argv[1]
digest = multihash.digest(value.encode(), "sha2-256")
encoded = multibase.encode(digest, "base58btc")
print(encoded)

Looks good to me. Thanks!

[dhh1128]

I'm trying to merge, but github is giving me an unexplained error. I'll check back later and try again; maybe their web server has indigestion.

[dhh1128]

Doesn't work a few minutes later on a different browser, either... :-(

[dhh1128]

Still not working, an hour later.

[dhh1128]

Still won't merge, 2 hours later.

[dhh1128]

Hooray, it finally merged!