search

decentralized-identity / peer-did-method-spec

A rich DID method that has no blockchain dependencies. The verifiable data registry is a synchronization protocol between peers.
https://decentralized-identity.github.io/peer-did-method-spec/index.html
Apache License 2.0
27 stars 17 forks source link

Address did:peer:2 spec changes #64

Open FabioPinheiro opened 8 months ago

FabioPinheiro commented 8 months ago

The goal of this ticket is just to track the adoption of the community for the specs change.

There are some spec changes for did:peer:2... that are breaking changes for DID Comm. In order to achieve interoperability. It's important to fix libraries that implement did:peer:2 and update all applications that depend on those libraries.

I'm pretty sure this list is far from being complete. Feel free to add to this list. Also, help us contact the maintainers by creating tickets on the respective libraries.

Context

The changes were merged in this commit https://github.com/decentralized-identity/peer-did-method-spec/commit/a5eca6b4e0e41f70364949f7008c30879cbcb3ad Both issues have possible mitigation solutions that allow a smoother migration. Although previous implementations are considered faulty! Since DID methods have no version.

Issue 1

The first is to fix the encoding to follow the DID Document. The DID Document's service example in did:peer looks like

"service":{
  ...
  "serviceEndpoint": "https://example.com/endpoint",
  "routingKeys": [...],
  "accept": [...]
}

But it should instead look like

"service":{
  ...
  "serviceEndpoint": {
    "uri":"https://example.com/endpoint",
    "routingKeys": [...],
    "accept": [...]
  }
}

We should make sure that our did:peer used on the applications are encoded correctly. when decrypting you look for that key

Issue 2

The second problem is about the id of the keys (kid). It was unspecified before. So each library generates the kid in its own way.

The major problem is that the kid is used on the DID Comm message itself. More specifically the field skid in the message's Protected Header is the kid of the sender and the recipients.header.kid is also the kid recipient. When decrypting you look for that key. So the agent encrypting and the agent decrypting MUST have the same or an equivalent resolver (the key id needs to be deterministic).

FabioPinheiro commented 8 months ago

https://identity.foundation/peer-did-method-spec/ I was expecting the specs web pages to be updated by the GitHub job. @dbluhm @swcurran do you know if the job failed or do we still need to do something?

dbluhm commented 8 months ago

https://identity.foundation/peer-did-method-spec/ I was expecting the specs web pages to be updated by the GitHub job. @dbluhm @swcurran do you know if the job failed or do we still need to do something?

It should have been updated... good catch, I'll investigate what went wrong!

dbluhm commented 8 months ago

Thanks for putting this issue together, by the way! This is excellent. We'll work on getting the didcomm-demo updated as well as the Indicio Mediator (no public repo to link to at the moment but feel free to add to your list). We will likely update those two projects in tandem.

mineme0110 commented 7 months ago

For sicpa peer-did-jvm library I have raised a PR which is an initiative to start the work required for the changes in PeerDID Spec https://github.com/sicpa-dlab/peer-did-jvm/pull/37 This PR doesn't handle all the PeerDID Spec changes required.

TheTechmage commented 7 months ago

Looking at the list, there's a library under the uniresolver that is missing. The veramo labs depends on a library that handles the actual parsing of DIDs and here's a PR for the fixes https://github.com/aviarytech/did-peer/pull/3

FabioPinheiro commented 6 months ago

Thanks @frostyfrog. So now we can update the version of @aviarytech/did-peer@0.0.24 in veramolabs/peer-did-resolver

mirceanis commented 5 months ago

@FabioPinheiro @frostyfrog I bumped the versions of the libraries in the uniresolver chain of dependencies. The last step is merging the changes in teh universal resolver repo: https://github.com/decentralized-identity/universal-resolver/pull/395

FabioPinheiro commented 5 months ago

@FabioPinheiro @frostyfrog I bumped the versions of the libraries in the uniresolver chain of dependencies. The last step is merging the changes in teh universal resolver repo: decentralized-identity/universal-resolver#395

That is great. I'm seeing a lot of fix/PRs for this lately. Let me try to update the list