Closed decentralgabe closed 2 years ago
it appears the tests fail because minimum
expects a number. I believe this is a problem with the test...
Ok...upon further investigation:
formatMaximum
and formatMinimum
are not defined in the Draft 7 specs:
There is a specific JS library that supports these additional fields...but it's not in the spec. So neither my change, nor the spec are correct and we probably need non-normative language to support non-integer min/max validation.
Edit: opened https://github.com/decentralized-identity/presentation-exchange/issues/312
@JaceHensley that library uses a non-normative json schema extension to define these properties...which isn't widely supported across json schema implementations
yeah I noticed that this week, I could've sworn I saw formatMinimum
on https://json-schema.org/ previously but when I went back to look at it again I couldn't find it.
What is formatMinimum anyway?
It's a minimum
, but the the comparison is based on the JSON schema format
(date, date-time, uri, uuid, ip, etc.)
@decentralgabe plz re-work, examples fixed in separate PR merged just now on call!
thanks @bumblefudge minor fixes - updated!
examples were using
formatMinimum
instead of the specifiedminimum