Remove Non-Normative JSON Schema Examples

decentralized-identity / presentation-exchange

Specification that codifies an inter-related pair of data formats for defining proof presentations (Presentation Definition) and subsequent proof submissions (Presentation Submission)

https://identity.foundation/presentation-exchange

Apache License 2.0

86 stars 37 forks source link

Remove Non-Normative JSON Schema Examples #317

Closed JaceHensley closed 2 years ago

JaceHensley commented 2 years ago

Closes https://github.com/decentralized-identity/presentation-exchange/issues/312

Ultimate Problem

The spec's examples included non-normative json schema for the filter property

Solution

Remove formatMinimum and formatMaximum from the examples
Add text explaining JSON Schema extensions and calling out that Holders SHOULD gracefully handle additional/unknown keywords.
- This is a SHOULD in the JSON Schema spec, so that's what I went with here

decentralgabe commented 2 years ago

I will update https://github.com/decentralized-identity/presentation-exchange/pull/311 after merge