decentralized-identity / presentation-exchange

Specification that codifies an inter-related pair of data formats for defining proof presentations (Presentation Definition) and subsequent proof submissions (Presentation Submission)
https://identity.foundation/presentation-exchange
Apache License 2.0
84 stars 37 forks source link

Add allow_self_issued and fix example Presentation Definition #372

Closed csuwildcat closed 1 year ago

brentzundel commented 1 year ago

How is this different from subject_is_issuer?

csuwildcat commented 1 year ago

Honestly forgot about it, but I think there's still something I'd add to subject_is_issuer: a value of "allowed" or "optional" , because the intent here is to signal that the input being described is not preferred or required to be from them, but merely open to it being so.

decentralgabe commented 1 year ago

Honestly forgot about it, but I think there's still something I'd add a value of "allowed" or "optional" to subject_is_issuer, because the intent here is to signal that the input being described is not preferred or required to be from them, but merely open to it being so.

@csuwildcat this is supported to - can be required or preferred https://identity.foundation/presentation-exchange/#relational-constraint-feature

csuwildcat commented 1 year ago

I'd also update the Note in that section to not be strictly about directing them to self-issue because you say so, but also note that it can be used as a signal that the JSON Schema inputs can be rendered in a form by a wallet for self-input of data. We're planning to do this in our wallet extension.

csuwildcat commented 1 year ago

Closing in favor of new subject_is_issuer value PR