decentralized-identity / presentation-exchange

Specification that codifies an inter-related pair of data formats for defining proof presentations (Presentation Definition) and subsequent proof submissions (Presentation Submission)
https://identity.foundation/presentation-exchange
Apache License 2.0
84 stars 36 forks source link

Specify a version of JSON Schema #480

Closed decentralgabe closed 4 months ago

decentralgabe commented 5 months ago

The examples all use Draft 7, which is old, but widely implemented. I would like to see this enshrined in the spec to reduce implementer confusion and prevent interop issues.

This is coming up in relation to:

If there are no strong objections I'd like to quickly move to amend 2.1 with this detial.

kimdhamilton commented 5 months ago

Thanks @decentralgabe! I reopened #303 since it looks like that was closed without resolution. I remember before cutting the 2.1 release, we asked around extensively because we were told generally of an issue related to JSON schema, but no one submitted details.

Are you saying that the root cause of all of these is that they use draft 7, but that is not specified? I'm still a bit unclear about the proposed change and how it addresses these.

But yes, if this addresses these problems, we'd welcome a PR (and details about how it relates to the above issues).

csuwildcat commented 5 months ago

@kimdhamilton I believe the root cause is they aren't using a current enough version, not one that's too new.

decentralgabe commented 5 months ago

Yes I believe implementers were using an older version that lacked some features like oneOf/anyOf. Specifying a draft that supports at least the features mentioned in PE itself should be sufficient to address the concern

kimdhamilton commented 5 months ago

Ok, this sounds fantastic -- this has been befuddling me for a while. Please proceed with the PR, and thanks again!

decentralgabe commented 4 months ago

https://github.com/decentralized-identity/presentation-exchange/pull/481