Align implementation with resolution metadata portion of the spec

decentralized-identity / sidetree-reference-impl

Sidetree Reference Implementation

Apache License 2.0

5 stars 7 forks source link

Align implementation with resolution metadata portion of the spec #14

Open thehenrytsai opened 3 years ago

thehenrytsai commented 3 years ago

The implementation deviated from the latest changes to the resolution metadata portion of the spec. e.g. deactivated property is newly added in the spec.

OR13 commented 3 years ago

You may want to add ION tests to did core test suite, at some point. for example: https://github.com/w3c/did-test-suite/pull/19

These would help did core cover cases like deactivated

OR13 commented 3 years ago

Provide concrete examples.... Spec should say this:

"didDocumentMetadata": {
    "deactivated": true,
    "canonicalId": "did:sidetree:EiDyOQbbZAa3aiRzeCkV7LOx3SERjjH93EXoIM3UoN4oWg",
    "method": {
      "published": true,
      "recoveryCommitment": "EiBfOZdMtU6OBw8Pk879QtZ-2J-9FbbjSZyoaA_bqD4zhA",
      "updateCommitment": "EiDOrcmPtfMHuwIWN6YoihdeIPxOKDHy3D6sdMXu_7CN0w"
    }
  }

csuwildcat commented 3 years ago

Action: Daniel update spec to reflect empty DID Doc with id prop if deactivated.

troyronda commented 3 years ago

Spec aspect is completed.

troyronda commented 3 years ago

@csuwildcat @thehenrytsai the test vector for after deactivate response is missing the deactivated flag. Split into decentralized-identity/sidetree#1052