search

decentralized-identity / sidetree-reference-impl

Sidetree Reference Implementation
Apache License 2.0
5 stars 7 forks source link

Consider removing the commit-reveal checks in `OperationProcessor`. #29

Open thehenrytsai opened 4 years ago

thehenrytsai commented 4 years ago

Technically, the commit-reveal checks is already performed by Resolver because it builds the commit-reveal lookup map, so the commit-reveal checks in OperationProcessor is current redundant.

One could make a case to remove these checks in OperationProcessor from the performance standpoint. One could also make a case to keep it from the design standpoint that OperationProcessor should not know the implementation details of the Resolver.

csuwildcat commented 4 years ago

I think this is the right move, because you're never going to build the commit reveal chain on ingest anyway, so there's no real benefit there, right?

thehenrytsai commented 4 years ago

To be clear, OperationProcessor is not the same as Observer. Observer is an ingest component, instances of OperationProcessor are not, they are the "processing engines" if you will, used in resolution for applying operations to derive the final DID state.