search

decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

Align resolution object with did core spec #1000

Closed isaacJChen closed 3 years ago

isaacJChen commented 3 years ago

Also addresses https://github.com/decentralized-identity/sidetree/issues/995

sandrask commented 3 years ago

@isaacJChen @thehenrytsai Couple of questions regarding this PR: 

  1. Why is top level context ("@context": "https://w3id.org/did-resolution/v1") missing in https://raw.githubusercontent.com/decentralized-identity/sidetree/master/tests/vectors/resolution/afterDeactivate.json
  2. Test vectors have an empty string for 'controller' in 'verificationMethod'. Does empty string for “controller” violate the spec? Should we omit “controller” if it is empty? Relevant sections of did core spec:  "A DID document MAY include a controller property to indicate the DID controller(s)."  and "When a controller property is present in a DID Document, its value expresses one or more DIDs."