search

decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

controller string should be populated to be more consistent with other DID implementations #1010

Open troyronda opened 3 years ago

troyronda commented 3 years ago

Re: https://github.com/decentralized-identity/sidetree/pull/1009#discussion_r561435869

https://github.com/decentralized-identity/sidetree/pull/1006#discussion_r561056101 @OR13 wrote:

I strongly recommend against returning the empty string for the controller property.... if makes sidetree look different than every other did method, and its not guaranteed to work accross JSON-LD implementations... the controller property should match the didDocument.id.

I agree - it is better to populate the controller property rather than leave it empty.

@thehenrytsai @OR13 @csuwildcat @sandrask @isaacJChen

OR13 commented 3 years ago

Is this a v1 issue?

OR13 commented 3 years ago

For example: https://github.com/transmute-industries/sidetree.js/blob/main/packages/test-vectors/src/sidetree-universal-wallet/wallet-operation.json#L37

^ we support controller like this.

llorllale commented 3 years ago

This isn't a consistency issue... this is a compliance issue.

From did-core:

controller The value of the controller property MUST be a string that conforms to the rules in § 3.1 DID Syntax.