search

decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

Fix undefined when calculating normalized fee #1183

Closed xinaxu closed 2 years ago

thehenrytsai commented 2 years ago

@xinaxu gentle ping regarding the 100% code coverage comment.

xinaxu commented 2 years ago

@xinaxu gentle ping regarding the 100% code coverage comment.

Done. Check again?

xinaxu commented 2 years ago

@thehenrytsai

thehenrytsai commented 2 years ago

Hey @xinaxu, can you also add a test to confirmation store so that it also hits 100% coverage? I know it is technically not part of this PR, but since the test file is already touched, which pointed me to coverage that was missed.

You can probably just search and copy existing test should create collection on initialization if it does not exist.

xinaxu commented 2 years ago

@thehenrytsai

xinaxu commented 2 years ago

but do remember again, that MS (currently you) will be responsible for testing against cosmosDB 'coz probably no one else will.

That's fine. If anything breaks, we will make a pull request. Anyway, even with tests disabled, no other people will run against cosmosdb so we are anyway on our own to validate the repo with cosmosdb

xinaxu commented 2 years ago

@thehenrytsai another option is to use a cosmosdb connection string as part of the github action and run the npm test against that cosmosdb. But let's do that when we have time.