decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

Define Operation Key and Recovery Key and correct JWS verification section #771

Closed OR13 closed 4 years ago

OR13 commented 4 years ago

Addresses: https://github.com/decentralized-identity/sidetree/issues/767

Defines keys, and their relationship to JWS and Commit Reveal.

Note that this section did not need to change: https://identity.foundation/sidetree/spec/#did-operations

implementers may choose to expose commitment values in the did document (because they are verification relationships, just like ethereum address).

May need to align with https://github.com/decentralized-identity/sidetree/pull/729.

OR13 commented 4 years ago

I noticed some ambiguity over the use of "update key" vs "operation key"... I have aligned with the defined term "operation key"... but I would be very much open to correcting this in a future PR to "update key".... there are a lot of changes here, this needs to be reviewed, and merged or we are going to have lots of merge conflicts...