search

decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

Document that `delta` size check is against the encoded string #772

Closed thehenrytsai closed 3 years ago

thehenrytsai commented 4 years ago

No spec on this, but delta size check should be against the decoded buffer, but currently size check is against the encoded buffer.

csuwildcat commented 3 years ago

"The canonicalized buffer of each Chunk File delta entry MUST NOT exceed the MAX_DELTA_SIZE" - this is what is in the spec, and what I believe we have implemented, @thehenrytsai. If this is true on both accounts, I can close this out as done.