search

decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

Spec: kid MUST be present in the protected header #841

Closed sandrask closed 3 years ago

sandrask commented 4 years ago

Step 1. in https://identity.foundation/sidetree/spec/#signing states:

  1. kid MUST be present in the protected header.

Reference application doesn't use kid and it expects only one header 'alg'. https://github.com/decentralized-identity/sidetree/blob/0dbf2c8ce6ef8981ebc6735066841bce39e2648f/lib/core/versions/latest/util/Jws.ts#L43

Also, fixtures don't have kid in the protected header.

OR13 commented 4 years ago

See also: https://github.com/decentralized-identity/did-jose-extensions/blob/master/options.md

OR13 commented 4 years ago

Recommend we change this to a MAY....

sandrask commented 4 years ago

I am ok with MAY

sandrask commented 3 years ago

This has been fixed.