search

decentralized-identity / sidetree

Sidetree Specification and Reference Implementation
https://identity.foundation/sidetree/spec
Apache License 2.0
438 stars 112 forks source link

Align remove-public-keys and remove-services on use of `ids` property #897

Closed csuwildcat closed 4 years ago

csuwildcat commented 4 years ago

Currently remove-public-keys uses a publicKeys field for its array of key ID strings to be removed, whereas remove-services uses ids for the same array of ID strings. We should change remove-public-keys to use the same ids property to normalize this.

NOTE: this has already been changed in the spec to reflect the use of ids as the property name in both places.

troyronda commented 4 years ago

Normalizing with ids makes sense to me.

thehenrytsai commented 4 years ago

Done.