Open henkvancann opened 3 years ago
package-lock.json changes seems to be included in this documentation PR.
On today's meeting, Daniel mentioned that we can use the GH CDN to link directly to images already on github to reduce asset creep:
https://rawgit.org/ , for example, turns this the ION logo already in the sidetree repo: https://github.com/decentralized-identity/sidetree/blob/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png into this: https://ghcdn.rawgit.org/decentralized-identity/sidetree/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png which can be linked from the QnA's
package-lock.json changes seems to be included in this documentation PR.
No idea how that entered my repo, but I've deleted it and synced with (pulled) the main repo to my repo on GitHub and went on from there. Issue should be solved.
On today's meeting, Daniel mentioned that we can use the GH CDN to link directly to images already on github to reduce asset creep:
https://rawgit.org/ , for example, turns this the ION logo already in the sidetree repo: https://github.com/decentralized-identity/sidetree/blob/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png into this: https://ghcdn.rawgit.org/decentralized-identity/sidetree/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png which can be linked from the QnA's
HvC: Yep, very good idea, however, work to be done after this PR as far as I am concerned.
Feel free to correct my initial creation of the Q-and-A of Sidetree.