search

decentralized-identity / universal-resolver

Universal Resolver implementation and drivers.
https://uniresolver.io/
Apache License 2.0
558 stars 246 forks source link

Earthid driver integration #441

Open vaibhavahire99 opened 1 month ago

vaibhavahire99 commented 1 month ago

This pull request removes the driver-did-earthid directory from the Universal Resolver repository to comply with best practices of separating the driver code from the Universal Resolver core. The changes made in this pull request ensure that the Universal Resolver configuration references the EarthID driver Docker image hosted externally, rather than including the driver code in this repository.

Key Changes: Removed driver-did-earthid directory:

The directory containing the EarthID driver code has been removed from the Universal Resolver repository. This ensures that the driver implementation can evolve independently and is maintained separately. Updated docker-compose.yml and configuration files:

The configuration now points to the vibhi09/driver-did-earthid:latest Docker image for resolving did:earthid identifiers. The resolver setup will continue to support EarthID DIDs by referencing the external Docker image.

peacekeeper commented 1 month ago

Thanks @vaibhavahire99 for your effort. This looks much better, but still one request.. This PR seems to add a lot of newlines to the docker-compose.yml file. Do you think you could also make this small change, so that you actually only add your driver and don't change other driver entries?

Also, this PR doesn't seem to add your driver to application.yml and .env and README.md, as described here: https://github.com/decentralized-identity/universal-resolver/blob/main/docs/driver-development.md

vaibhavahire99 commented 1 month ago

Hi thanks @peacekeeper. I've made the changes as mentioned. Can you please take a look and let me know if works.

BernhardFuchs commented 1 month ago

Hi,
I've just tested the driver and on startup it throws following error:

exec /usr/local/bin/docker-entrypoint.sh: exec format error
peacekeeper commented 3 weeks ago

@vaibhavahire99 It seems there are merge conflicts now that need to be resolved..

vaibhavahire99 commented 3 weeks ago

Hi @peacekeeper, I've resolved the conflicts can you please take a look and let me know. Thank you

BernhardFuchs commented 3 weeks ago

Pls fix the issues with indendation and resolve new merge conflicts. We added a new driver in the meantime and that created new conflicts

vaibhavahire99 commented 2 weeks ago

Hi @BernhardFuchs, I've resolved the conflicts and the indendation issues. Can you please check and let me know if any changes.

BernhardFuchs commented 2 weeks ago

There is still following error thrown:

exec /usr/local/bin/docker-entrypoint.sh: exec format error
vaibhavahire99 commented 2 weeks ago

Hi @BernhardFuchs, I've updated the platform dependency. Can you please check now and let me know if any changes. Thanks!

BernhardFuchs commented 2 weeks ago

Thx for the update but the driver still throws the same error on startup:

exec /usr/local/bin/docker-entrypoint.sh: exec format error
peacekeeper commented 2 weeks ago

I also tried it and got the same error as @BernhardFuchs .

@vaibhavahire99 Have you tried testing your own driver locally according to https://github.com/decentralized-identity/universal-resolver/blob/main/docs/driver-development.md#how-to-test-a-driver-locally ?