Closed mirceanis closed 9 months ago
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
ecdb2a2
) 84.85% compared to head (08e4ab0
) 84.85%. Report is 7 commits behind head on next.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What issue is this PR fixing
fixes #1215
What is being changed
DIDManager
no longer relies on thealias
+provider
pair when storing or filtering identifiers. It is now impossible to use the same alias on 2 identifiers from different providers.didManagerGetOrCreate
still accepts aprovider
param in case it needs to create a new DID, but if it encounters an identifier with an existingalias
but using a differentprovider
it will throw an error.AbstractDIDStore.getDID()
no longer uses aprovider
parameter.@veramo/data-store
and@veramo/data-store-json
packages have been adapted to match the expected behavior of the DID managerQuality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.Details
BREAKING CHANGE: The behavior of
DIDManager
has changed when working withalias
. It is mostly ignoringprovider
unless it is used to create new identifiers.AbstractDIDStore
APIs have been adapted and implementations have changed.Merging this PR into
main
will trigger a new major release