decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
415 stars 129 forks source link

feat(did-manager): matching DIDs by alias should not depend on the provider #1218

Closed mirceanis closed 9 months ago

mirceanis commented 11 months ago

What issue is this PR fixing

fixes #1215

What is being changed

Quality

Check all that apply:

Details

BREAKING CHANGE: The behavior of DIDManager has changed when working with alias. It is mostly ignoring provider unless it is used to create new identifiers. AbstractDIDStore APIs have been adapted and implementations have changed.

Merging this PR into main will trigger a new major release

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ecdb2a2) 84.85% compared to head (08e4ab0) 84.85%. Report is 7 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1218 +/- ## ======================================= Coverage 84.85% 84.85% ======================================= Files 167 167 Lines 18065 18071 +6 Branches 2028 2029 +1 ======================================= + Hits 15329 15335 +6 Misses 2736 2736 ``` | [Files Changed](https://app.codecov.io/gh/uport-project/veramo/pull/1218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project) | Coverage Δ | | |---|---|---| | [...ckages/data-store-json/src/identifier/did-store.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGF0YS1zdG9yZS1qc29uL3NyYy9pZGVudGlmaWVyL2RpZC1zdG9yZS50cw==) | `92.52% <100.00%> (ø)` | | | [packages/data-store/src/identifier/did-store.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGF0YS1zdG9yZS9zcmMvaWRlbnRpZmllci9kaWQtc3RvcmUudHM=) | `96.66% <100.00%> (ø)` | | | [...kages/did-manager/src/abstract-identifier-store.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGlkLW1hbmFnZXIvc3JjL2Fic3RyYWN0LWlkZW50aWZpZXItc3RvcmUudHM=) | `100.00% <100.00%> (ø)` | | | [packages/did-manager/src/id-manager.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGlkLW1hbmFnZXIvc3JjL2lkLW1hbmFnZXIudHM=) | `90.74% <100.00%> (+0.21%)` | :arrow_up: | | [packages/did-manager/src/memory-did-store.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGlkLW1hbmFnZXIvc3JjL21lbW9yeS1kaWQtc3RvcmUudHM=) | `91.30% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.