decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
415 stars 129 forks source link

feat: using IPFS CID instead of hex blake2 hashes #1239

Closed simonas-notcat closed 10 months ago

simonas-notcat commented 10 months ago

What issue is this PR fixing

This PR is changing hashing algorithm from blake2 to the one that is being used by IPFS

What is being changed

@veramo/utils computeEntryHash now uses another hash algorithm. It is mainly used for computing a unique hash for VerifiableCredentials when storing them in the DB

Quality

Check all that apply:

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fcd2699) 84.92% compared to head (42c255c) 84.93%. Report is 2 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1239 +/- ## ======================================= Coverage 84.92% 84.93% ======================================= Files 167 167 Lines 18120 18132 +12 Branches 2036 2036 ======================================= + Hits 15388 15400 +12 Misses 2732 2732 ``` | [Files Changed](https://app.codecov.io/gh/uport-project/veramo/pull/1239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project) | Coverage Δ | | |---|---|---| | [packages/utils/src/credential-utils.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvdXRpbHMvc3JjL2NyZWRlbnRpYWwtdXRpbHMudHM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.