decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
414 stars 130 forks source link

fix(data-store): order skip take in orm and json #1243

Closed simonas-notcat closed 9 months ago

simonas-notcat commented 9 months ago

What issue is this PR fixing

There were 2 issues when running

await agent.dataStoreORMGetVerifiableCredentials({
  order: [{ column: 'issuanceDate', direction: 'ASC' }],
  take: 1,
  skip: 1
})

Quality

Check all that apply:

codecov[bot] commented 9 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (e8c270f) 84.89% compared to head (ec0dc2e) 84.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1243 +/- ## ========================================== + Coverage 84.89% 84.92% +0.02% ========================================== Files 167 167 Lines 18113 18120 +7 Branches 2032 2036 +4 ========================================== + Hits 15377 15388 +11 + Misses 2736 2732 -4 ``` | [Files Changed](https://app.codecov.io/gh/uport-project/veramo/pull/1243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project) | Coverage Δ | | |---|---|---| | [packages/data-store-json/src/data-store-json.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGF0YS1zdG9yZS1qc29uL3NyYy9kYXRhLXN0b3JlLWpzb24udHM=) | `92.30% <100.00%> (+0.73%)` | :arrow_up: | | [packages/data-store/src/data-store-orm.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvZGF0YS1zdG9yZS9zcmMvZGF0YS1zdG9yZS1vcm0udHM=) | `90.39% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.