decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
431 stars 131 forks source link

fix(utils): synchronous version of sha256 digest #1253

Closed simonas-notcat closed 1 year ago

simonas-notcat commented 1 year ago

What issue is this PR fixing

Native browser crypto API is async We need a sync version of sha256 for the computeEntryHash method.

https://stackoverflow.com/a/73600052

Quality

Check all that apply:

Details

If applicable, add screen captures, error messages or stack traces to help explain your problem.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (e2e794f) 84.93% compared to head (5396c5e) 84.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1253 +/- ## ========================================== - Coverage 84.93% 84.93% -0.01% ========================================== Files 167 167 Lines 18132 18131 -1 Branches 2036 2036 ========================================== - Hits 15400 15399 -1 Misses 2732 2732 ``` | [Files Changed](https://app.codecov.io/gh/uport-project/veramo/pull/1253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project) | Coverage Δ | | |---|---|---| | [packages/utils/src/credential-utils.ts](https://app.codecov.io/gh/uport-project/veramo/pull/1253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uport-project#diff-cGFja2FnZXMvdXRpbHMvc3JjL2NyZWRlbnRpYWwtdXRpbHMudHM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.