Closed mirceanis closed 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
eb82bdc
) 84.92% compared to head (d4a7f44
) 84.92%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What issue is this PR fixing
fixes #1269
What is being changed
When deleting a credential, the corresponding claims are matched by the credential
hash
(internally computed) instead of the credentialid
which is optional.Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.Details
I included the tests in the
localJsonStoreAgent
test suite as well to ensure similar behavior. The@veramo/data-store-json
did not manifest the same bug, but I added it to check for regressions.This is a hotfix that should be release before the next major release