decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
414 stars 130 forks source link

fix(credential-ld): let verifiers use all supported verification methods #1331

Closed mirceanis closed 5 months ago

mirceanis commented 5 months ago

What issue is this PR fixing

fixes #1329

What is being changed

The VeramoLdSignature.getSupportedVerificationType() can now return string[] as well as string This allows VeramoLdSignature suite implementations to signal compatibility with multiple Verification Method types for verification.

Quality

Check all that apply:

codecov-commenter commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7896cea) 89.83% compared to head (cde68aa) 89.83%.

Files Patch % Lines
...s/credential-ld/src/suites/JsonWebSignature2020.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1331 +/- ## ======================================= Coverage 89.83% 89.83% ======================================= Files 176 176 Lines 27010 27017 +7 Branches 2120 2124 +4 ======================================= + Hits 24265 24272 +7 Misses 2745 2745 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.