Closed mirceanis closed 5 months ago
Attention: 25 lines
in your changes are missing coverage. Please review.
Comparison is base (
7896cea
) 89.83% compared to head (1df297e
) 89.84%.
Files | Patch % | Lines |
---|---|---|
packages/did-provider-key/src/resolver.ts | 91.33% | 24 Missing :warning: |
...s/credential-ld/src/suites/JsonWebSignature2020.ts | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What issue is this PR fixing
fixes #1330
What is being changed
The did:key resolver implementations imported from transmute resolved to outdated Verification method formats. This PR replaces those dependencies with a local implementation that also adheres better to the spec for defaults and behavior.
The verification methods default to
JsonWebKey2020
, unless otherwise specified through theoptions.publicKeyFormat
parameter. This implementation also supportsoptions.enableEncryptionKeyDerivation
, defaulting totrue
, that triggers the expression of the corresponding X25519keyAgreement
key for an Ed25519 public key.This implementation supports
Ed25519
,X25519
,Secp256k1
, andP-256
key types for did:key.Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.Notes
This PR is based on #1331, as changing the default verification methods in did:key triggers the corner case signaled in #1329 and fixed in #1331