decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
431 stars 131 forks source link

fix: address edge case when getting DIDDoc component #1365

Closed nickreynolds closed 6 months ago

nickreynolds commented 6 months ago

What issue is this PR fixing

fixes #1364

What is being changed

The getDIDComponentById function in did-resolver/src/resolver.ts is modified so that it correctly finds the result when the didUrl passed in is a keyID without the DID prefixed to it, but the resolved DID Document lists the key with the prefix.

Quality

Check all that apply:

Details

it's possible that this is not the ideal solution and the proper fix for the bug is upstream from this function

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.95%. Comparing base (ab16cbd) to head (7d1ad28).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1365 +/- ## ======================================= Coverage 89.95% 89.95% ======================================= Files 176 176 Lines 27695 27695 Branches 2200 2200 ======================================= Hits 24912 24912 Misses 2783 2783 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.