search

decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
414 stars 130 forks source link

Message attachments should be saved #1377

Closed paksa92 closed 3 hours ago

paksa92 commented 2 months ago

Is your feature request related to a problem? Please describe. Message attachments are currently not saved, as it's missing in the Message entity and typeorm migrations in the data-store package.

Describe the solution you'd like I want message attachments to be saved in the agent's data store.

Additional context I'm working on a PR that adds this, but I'm wondering if there's a reason why this is missing?

mirceanis commented 2 months ago

It isn't intentionally omitted. A pr would be welcome.

Messages are also saved in raw, which should mean "as they are received". I believe attachments should still be there in the raw message.

paksa92 commented 2 months ago

Yes, they are in indeed there in the raw message.

Tests are failing in the next branch it seems. Will look into it in the coming days.

stale[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.