decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
414 stars 130 forks source link

refactor(credential-w3c): remove hardcoded proof formats #1395

Open nickreynolds opened 5 days ago

nickreynolds commented 5 days ago

What issue is this PR fixing

What is being changed

Quality

Check all that apply:

Note

this is an alternative refactor to #1394

codecov-commenter commented 1 day ago

Codecov Report

Attention: Patch coverage is 92.78729% with 59 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (2110590) to head (04ad9e5).

Files Patch % Lines
.../credential-jwt/src/agent/CredentialProviderJWT.ts 95.59% 16 Missing :warning:
...ntial-eip712/src/agent/CredentialProviderEIP712.ts 81.57% 14 Missing :warning:
packages/utils/src/did-utils.ts 12.50% 14 Missing :warning:
packages/credential-w3c/src/action-handler.ts 89.91% 12 Missing :warning:
packages/credential-ld/src/CredentialProviderLD.ts 96.72% 2 Missing :warning:
...s/credential-ld/src/suites/JsonWebSignature2020.ts 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1395 +/- ## ========================================== - Coverage 89.79% 89.73% -0.06% ========================================== Files 176 177 +1 Lines 27791 26848 -943 Branches 2208 2220 +12 ========================================== - Hits 24954 24092 -862 + Misses 2837 2756 -81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.