Closed mirceanis closed 4 months ago
Attention: Patch coverage is 96.42857%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 89.72%. Comparing base (
018e189
) to head (e2f8159
).
Files | Patch % | Lines |
---|---|---|
...kages/did-comm/src/encryption/a256cbc-hs512-dir.ts | 92.30% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What issue is this PR fixing
fixes #1381 fixes #1387
What is being changed
Removed
isomorphic-webcrypto
dependency in favor of@noble/ciphers
+@noble/hashes
. This also allowed us to remove several other@stablelib/*
dependencies from the@veramo/did-comm
package.I also updated the encryption tests to include the test-vectors that were previously unused.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.