decentralized-identity / veramo

A JavaScript Framework for Verifiable Data
https://veramo.io
Apache License 2.0
443 stars 133 forks source link

fix(did-comm): remove isomorphic-webcrypto dependency #1401

Closed mirceanis closed 4 months ago

mirceanis commented 4 months ago

What issue is this PR fixing

fixes #1381 fixes #1387

What is being changed

Removed isomorphic-webcrypto dependency in favor of @noble/ciphers + @noble/hashes. This also allowed us to remove several other @stablelib/* dependencies from the @veramo/did-comm package.

I also updated the encryption tests to include the test-vectors that were previously unused.

Quality

Check all that apply:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (018e189) to head (e2f8159).

Files Patch % Lines
...kages/did-comm/src/encryption/a256cbc-hs512-dir.ts 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #1401 +/- ## ========================================== - Coverage 89.73% 89.72% -0.02% ========================================== Files 177 177 Lines 26846 26810 -36 Branches 2220 2220 ========================================== - Hits 24090 24054 -36 Misses 2756 2756 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.