PR generated to test if all tests work

decentralized-identity / veramo

A JavaScript Framework for Verifiable Data

https://veramo.io

Apache License 2.0

443 stars 133 forks source link

PR generated to test if all tests work #1411

Closed veromassera closed 3 months ago

veromassera commented 3 months ago

Quality

Check all that apply:

[X] I want these changes to be integrated
[ ] I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
[ ] I allow my PR to be updated by the reviewers (to speed up the review process).
[ ] I added unit tests.
[ ] I added integration tests.
[ ] I did not add automated tests because _____, and I am aware that a PR without tests will likely get rejected.

Details

PR generated to test if all tests work

veromassera commented 3 months ago

In this PR I did not introduce any changes and the jest-dev-server Failed to compile. I don't see a way to fix the React tests in the credential-bbs PR

nickreynolds commented 2 months ago

@veromassera very interesting. I will take a look at this when I'm back from vacation next week.

Assuming we can get the tests passing correctly without your PR, we will probably want to modify the browser tests to exercise your code (and possibly add to the react-native tutorial as well), but we can discuss that after we fix the tests. Will get back to you next week!

veromassera commented 2 months ago

@nickreynolds Perfect. Happy holidays!

nickreynolds commented 2 months ago

@veromassera I did some more digging, and it appears that an integration test is failing because a 3rd party service we used (did.actor) is no longer operational (which is why the tests started failing even though we didn't merge any changes). I'm looking to find a replacement, or will otherwise just remove the 2 failing tests. I'm not sure it will fix your issue, as I think the failed tests I was seeing on your PR were unrelated and started before this service was turned off, but I will let you know when it's fixed and we can check again

veromassera commented 2 months ago

Hi Nick @nickreynolds , Thanks for looking into this. I think my PR should be good to go once the test issues are fixed. I was running into a problem with a React test dependency, but I managed to sort it out using vm-browserify.

I look forward to hearing from you.