search

decentralized-identity / waci-didcomm

Wallet And Credential Interactions for DIDComm
https://identity.foundation/waci-didcomm
Apache License 2.0
12 stars 12 forks source link

Are test vectors correct? #10

Open OR13 opened 2 years ago

OR13 commented 2 years ago

hello, is this example wrong in “WACI-DIDComm Interop Profile” section 7.2 Presentation step 3. The sequence diagram in section 6.2 Presentation describers this step is from Verifier to Wallet, but the example is:

  "from": "did:example:prover",
  "to": [
    "did:example:verifier"
  ],
OR13 commented 2 years ago

Confirmed on the call, from and to are indeed reversed.

echenknox commented 2 years ago

Hello, thanks for addressing the issue. I just want to mention that step 7.2.4 is reversed as well.

OR13 commented 2 years ago

This can be closed when the new spec link has been determined to not have. the reported issue above ^

rolsonquadras commented 2 years ago

Hello, thanks for addressing the issue. I just want to mention that step 7.2.4 is reversed as well.

Link to the new spec (waci-didcomm) - https://identity.foundation/waci-didcomm/#step-4-present-proof