decentralized-identity / waci-didcomm

Wallet And Credential Interactions for DIDComm
https://identity.foundation/waci-didcomm
Apache License 2.0
12 stars 12 forks source link

CredentialFulfillment JSON-LD Document is missing. #32

Open apelt opened 1 year ago

apelt commented 1 year ago

CredentialFulfillment JSON-LD Document is not available at: https://identity.foundation/credential-manifest/fulfillment/v1

Therefore VerifiablePresentation/CredentialFulfillment cannot be canonicalized (processed with JSON-LD Processors) and signed as shown in example: 7.1.5 Step 5 : Issue Credential

Btw why must the issuer in Step 5 sign both Verifiable Credential and VerifiablePresentation (CredentialFulfillment)? Isn't signature over Verifiable Credential enough?

apelt commented 1 year ago

This is missing (created by myself):

{

    "@context":{
        "@version":1.1,
        "CredentialFulfillment":{
            "@id":"https://identity.foundation/credential-manifest/#credential-fulfillment",
            "@context":{
                "@version":1.1,
                "credential_fulfillment":{
                    "@id":"https://identity.foundation/credential-manifest/#credential-fulfillment",
                    "@type":"@json"
                }
            }
        }
    }

}

It seems the CredentialFulfillment was replaced by CredentialResponse (https://identity.foundation/credential-manifest/#credential-response-2). The WACI-DIDComm Interop Profile is outdated.