decentralized-identity / wallet-rendering

Specifications for rendering DID and Credential-centric data in wallet applications
https://identity.foundation/wallet-rendering
Apache License 2.0
8 stars 2 forks source link

URI format doesn't work with newer `ajv` lib #28

Open andorsk opened 1 year ago

andorsk commented 1 year ago

Expected: upgrade libs and all tests pass Actual: Entity schema tests fails with URI format. AJV was anchored on the test suite at 6.12.5. Upgrade breaks the test.

Valid Entity Schema Test:
     Error: unknown format "uri" ignored in schema at path "#/definitions/image/properties/uri"

Recent AJV lib 8.12.0 does not permit uri as schema format, and test will fail.

-    "ajv": "^8.12.0",
+    "ajv": "^6.12.5",

Suggested fixes:

bumblefudge commented 1 year ago

just need to be explicit about which JSON Schema drafts work with v1 when we publish v1

andorsk commented 1 year ago

yea..the weird thing about this to be clear: It's the same schema. Just a different version of the lib processing this. 🤷

brentzundel commented 1 year ago

editorial changes in v1 (unless we get the actual fix in place) actual fix in v2