decentralized-identity / wallet-rendering

Specifications for rendering DID and Credential-centric data in wallet applications
https://identity.foundation/wallet-rendering
Apache License 2.0
8 stars 2 forks source link

Allow arrays to be displayed in wallet #4

Open JaceHensley opened 2 years ago

JaceHensley commented 2 years ago

We should allow arrays to be displayed to in a wallet. The items must be of type "string", "boolean", "number", "integer", or "array" (nested arrays)

bumblefudge commented 2 years ago

good suggestion on the call: inherit (or at least get inspo from) the OpenAPI data types

andorsk commented 2 years ago

specifically here: https://swagger.io/docs/specification/data-models/data-types/

brentzundel commented 1 year ago

also want this capability for arrays: https://github.com/decentralized-identity/wallet-rendering/issues/5#issue-1102078251

colbyharrison commented 1 year ago

Arrays of Objects should be included in this.

andorsk commented 1 year ago

I'm don't see a really good reason not to use the existing openapi types to do this. In fact, there's a ton of other standards we could add in from there including OneOf, etc. I think openapi types are actually very similar to JSONSchema ( if not identical ), but that seems like a reasonable way to move this forward.

Example: String array

{
  "type": "array",
  "items": 
    "type": "string"
}

Example: Object array

{
  "type": "array",
  "items": 
    "type": "object"
}

Example: Object array with properties

{
  "type": "array",
  "items": 
    "type": "object"
     "properties": {
        "id": {
           "type: "string"
        }
      }
}

The big concern here is it might be quite a big update to the specifications, so it might make sense to break this out into multiple PRs.

andorsk commented 1 year ago

Referencing the actual link here: https://identity.foundation/wallet-rendering/#using-path, where the issue is referencing.

andorsk commented 1 year ago

@brentzundel @csuwildcat Can we put this on the agenda for the next CC call. I have some thoughts here but I think this could end up being a larger change to the spec than a few tweaks, so I'd like to discuss first before putting a proposal together.

andorsk commented 1 year ago

linking to https://github.com/decentralized-identity/wallet-rendering/issues/21 as relevant.

bumblefudge commented 1 year ago

v1 or v2, important question for next week (shout out to colby for mentioning on today's call ) :D