search

decheine / complete-compendium

AD&D 2nd Edition Complete* Monstrous Compendium.
https://completecompendium.com/
16 stars 8 forks source link

Change Fainil source to Dragon 244 #221

Closed gene1wood closed 3 months ago

gene1wood commented 4 months ago

This is in Dragon 244 page 26 This relates to #95

decheine commented 4 months ago

Thank you for the contributions! When making changes to monster source files, the compendium will need to be rebuilt. You'll need Docker but that's it.

First, run the combined command to build and harvest the monsters:

docker build -t monster-harvester -f harvester/Dockerfile .; docker create --name harvester-container monster-harvester; Foreach-Object { docker cp "harvester-container:/usr/local/harvester/build/bin/json_files" output }

Then run the helper script that copies the generated files to the repository:

node scripts/copy_monster_data.js

Then test it to see if the changes showed up right. If you have any questions let me know!

gene1wood commented 4 months ago

Great! I wasn't clear reading the README if a PR should contain just the source change or also the rendered change. I'll update this PR with that.

You may want to add that to the README, maybe a small section about how to contribute (with those types of commands you mention above)

decheine commented 4 months ago

For sure, I do have these commands in the Readme at the bottom but the contributing section could use some work/have its own page. Those are the two lines you need to build everything so I should highlight that more clearly.

decheine commented 4 months ago

It's usually best to just do the whole book at once, so you only have to build/run the harvester once.

decheine commented 3 months ago

Pushed 1c0f66b320f0282e0e5b16b19fc30f531003d187, the monsters in this book are complete. Thanks for this!

gene1wood commented 3 months ago

Thank you! Sorry I got swamped and wasn't able to render the content and update the PR